[ 
https://issues.apache.org/jira/browse/ARROW-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16252764#comment-16252764
 ] 

ASF GitHub Bot commented on ARROW-1476:
---------------------------------------

siddharthteotia commented on issue #1316: ARROW-1476: [JAVA] Implement Final 
ValueVector Updates
URL: https://github.com/apache/arrow/pull/1316#issuecomment-344448860
 
 
   There was one more problem. When JsonFileReader was  refactored recently 
while removing the static interfaces, we did not set the writer index on the 
buffers we are allocating for the vector. As we are parsing JSON and writing to 
buffers, we should be setting writer index before calling loadFieldBuffers(). 
   
   The static interfaces were doing so but we missed doing that in the recent 
change

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> [JAVA] Implement final ValueVector updates
> ------------------------------------------
>
>                 Key: ARROW-1476
>                 URL: https://issues.apache.org/jira/browse/ARROW-1476
>             Project: Apache Arrow
>          Issue Type: Sub-task
>            Reporter: Jacques Nadeau
>            Assignee: Siddharth Teotia
>              Labels: pull-request-available
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to