[
https://issues.apache.org/jira/browse/ARROW-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16252676#comment-16252676
]
ASF GitHub Bot commented on ARROW-1476:
---------------------------------------
siddharthteotia commented on issue #1316: ARROW-1476: [JAVA] Implement Final
ValueVector Updates
URL: https://github.com/apache/arrow/pull/1316#issuecomment-344434176
Thanks @icexelloss . It looks like the loadFieldBuffers code in new vector
is missing some special handling of validity buffer. However, as per the old
load code I am not sure when (and why) will the readable bytes be 0 and value
count non-zero --
https://github.com/apache/arrow/blob/master/java/vector/src/main/java/org/apache/arrow/vector/BitVector.java#L57
If the condition is not fulfilled then it does what the new code is doing --
associate the buffer with target allocator. I am not quite sure when will the
specialized handling be exercised?
Whether the vector is all NULLs or not, the buffer cannot be empty if the
value count is non-zero. Am I missing something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [JAVA] Implement final ValueVector updates
> ------------------------------------------
>
> Key: ARROW-1476
> URL: https://issues.apache.org/jira/browse/ARROW-1476
> Project: Apache Arrow
> Issue Type: Sub-task
> Reporter: Jacques Nadeau
> Assignee: Siddharth Teotia
> Labels: pull-request-available
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
