[
https://issues.apache.org/jira/browse/ARROW-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16258558#comment-16258558
]
ASF GitHub Bot commented on ARROW-1693:
---------------------------------------
wesm commented on issue #1294: ARROW-1693: [JS] Fix reading C++
dictionary-encoded vectors
URL: https://github.com/apache/arrow/pull/1294#issuecomment-345539857
See
```
Error message: Invalid:
/home/travis/build/apache/arrow/cpp/src/arrow/ipc/json-integration-test.cc:89
code: reader->ReadRecordBatch(i, &batch)
/home/travis/build/apache/arrow/cpp/src/arrow/ipc/json-internal.cc:1435
code: ReadArray(pool, json_columns[i], type, &columns[i])
/home/travis/build/apache/arrow/cpp/src/arrow/ipc/json-internal.cc:1287
code: ParseTypeValues(*type_)
/home/travis/build/apache/arrow/cpp/src/arrow/ipc/json-internal.cc:1055
code: ParseHexValue(hex_data + j * 2, &byte_buffer_data[j])
Encountered non-hex digit
Command failed:
/home/travis/build/apache/arrow/cpp-build/debug/json-integration-test
--integration --mode=JSON_TO_ARROW
--json=/home/travis/build/apache/arrow/js/test/data/json/primitive.json
--arrow=/home/travis/build/apache/arrow/js/test/data/cpp/file/primitive.arrow
```
It looks like there is something wrong with the JSON files that have been
written to that directory. I will take a closer look
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [JS] Error reading dictionary-encoded integration test files
> ------------------------------------------------------------
>
> Key: ARROW-1693
> URL: https://issues.apache.org/jira/browse/ARROW-1693
> Project: Apache Arrow
> Issue Type: Bug
> Components: JavaScript
> Reporter: Brian Hulette
> Assignee: Paul Taylor
> Labels: pull-request-available
> Fix For: 0.8.0
>
> Attachments: dictionary-cpp.arrow, dictionary-java.arrow,
> dictionary.json
>
>
> The JS implementation crashes when reading the dictionary test case from the
> integration tests.
> To replicate, first generate the test files with java and cpp impls:
> {code}
> $ cd ${ARROW_HOME}/integration/
> $ python -c 'from integration_test import generate_dictionary_case;
> generate_dictionary_case().write("dictionary.json")'
> $ ../cpp/debug/debug/json-integration-test --integration
> --json=dictionary.json --arrow=dictionary-cpp.arrow --mode=JSON_TO_ARROW
> $ java -cp
> ../java/tools/target/arrow-tools-0.8.0-SNAPSHOT-jar-with-dependencies.jar
> org.apache.arrow.tools.Integration -c JSON_TO_ARROW -a dictionary-java.arrow
> -j dictionary.json
> {code}
> Attempt to read the files with the JS impl:
> {code}
> $ cd ${ARROW_HOME}/js/
> $ ./bin/arrow2csv.js -s dict1_0 -f ../integration/dictionary-{java,cpp}.arrow
> {code}
> Both files result in an error for me on
> [a8f51858|https://github.com/apache/arrow/commit/a8f518588fda471b2e3cc8e0f0064e7c4bb99899]:
> {{TypeError: Cannot read property 'buffer' of undefined}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
