[
https://issues.apache.org/jira/browse/ARROW-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16258701#comment-16258701
]
ASF GitHub Bot commented on ARROW-1693:
---------------------------------------
wesm commented on issue #1294: ARROW-1693: [JS] Fix reading C++
dictionary-encoded vectors
URL: https://github.com/apache/arrow/pull/1294#issuecomment-345566713
There was a non-deterministic Plasma failure in the C++/Python entry, but
the integration test entry also failed:
```
[00:23:46] Starting 'test:es5:umd'...
FAIL test/table-tests.ts
● Test suite failed to run
Cannot find module
'/home/travis/build/apache/arrow/js/targets/es5/umd/Arrow' from 'Arrow.ts'
at Resolver.resolveModule
(node_modules/jest-resolve/build/index.js:191:17)
at Object.<anonymous> (test/Arrow.ts:50:17)
FAIL test/reader-tests.ts
● Test suite failed to run
Cannot find module
'/home/travis/build/apache/arrow/js/targets/es5/umd/Arrow' from 'Arrow.ts'
at Resolver.resolveModule
(node_modules/jest-resolve/build/index.js:191:17)
at Object.<anonymous> (test/Arrow.ts:50:17)
FAIL test/integration-tests.ts
● Test suite failed to run
Cannot find module
'/home/travis/build/apache/arrow/js/targets/es5/umd/Arrow' from 'Arrow.ts'
at Resolver.resolveModule
(node_modules/jest-resolve/build/index.js:191:17)
at Object.<anonymous> (test/Arrow.ts:50:17)
FAIL test/vector-tests.ts
● Test suite failed to run
Cannot find module
'/home/travis/build/apache/arrow/js/targets/es5/umd/Arrow' from 'Arrow.ts'
at Resolver.resolveModule
(node_modules/jest-resolve/build/index.js:191:17)
at Object.<anonymous> (test/Arrow.ts:50:17)
Test Suites: 4 failed, 4 total
Tests: 0 total
Snapshots: 0 total
Time: 2.409s, estimated 24s
Ran all test suites.
[00:23:49] 'test:es5:umd' errored after 2.64 s
[00:23:49] Error: exited with error code: 1
at ChildProcess.onexit
(/home/travis/build/apache/arrow/js/node_modules/end-of-stream/index.js:39:36)
at ChildProcess.emit (events.js:159:13)
at Process.ChildProcess._handle.onexit (internal/child_process.js:209:12)
[00:23:49] 'test' errored after 3.42 min
npm ERR! Test failed. See above for more details.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [JS] Error reading dictionary-encoded integration test files
> ------------------------------------------------------------
>
> Key: ARROW-1693
> URL: https://issues.apache.org/jira/browse/ARROW-1693
> Project: Apache Arrow
> Issue Type: Bug
> Components: JavaScript
> Reporter: Brian Hulette
> Assignee: Paul Taylor
> Labels: pull-request-available
> Fix For: 0.8.0
>
> Attachments: dictionary-cpp.arrow, dictionary-java.arrow,
> dictionary.json
>
>
> The JS implementation crashes when reading the dictionary test case from the
> integration tests.
> To replicate, first generate the test files with java and cpp impls:
> {code}
> $ cd ${ARROW_HOME}/integration/
> $ python -c 'from integration_test import generate_dictionary_case;
> generate_dictionary_case().write("dictionary.json")'
> $ ../cpp/debug/debug/json-integration-test --integration
> --json=dictionary.json --arrow=dictionary-cpp.arrow --mode=JSON_TO_ARROW
> $ java -cp
> ../java/tools/target/arrow-tools-0.8.0-SNAPSHOT-jar-with-dependencies.jar
> org.apache.arrow.tools.Integration -c JSON_TO_ARROW -a dictionary-java.arrow
> -j dictionary.json
> {code}
> Attempt to read the files with the JS impl:
> {code}
> $ cd ${ARROW_HOME}/js/
> $ ./bin/arrow2csv.js -s dict1_0 -f ../integration/dictionary-{java,cpp}.arrow
> {code}
> Both files result in an error for me on
> [a8f51858|https://github.com/apache/arrow/commit/a8f518588fda471b2e3cc8e0f0064e7c4bb99899]:
> {{TypeError: Cannot read property 'buffer' of undefined}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
