[
https://issues.apache.org/jira/browse/ARROW-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266586#comment-16266586
]
ASF GitHub Bot commented on ARROW-1755:
---------------------------------------
MaxRis commented on a change in pull request #1333: ARROW-1755: [C++] CMake
option to link msvc crt statically
URL: https://github.com/apache/arrow/pull/1333#discussion_r153148017
##########
File path: appveyor.yml
##########
@@ -40,6 +40,18 @@ environment:
PYTHON: "3.5"
ARCH: "64"
CONFIGURATION: "Release"
+ - JOB: "Build_Debug"
+ GENERATOR: Visual Studio 14 2015 Win64
+ PYTHON: "3.5"
+ ARCH: "64"
+ CONFIGURATION: "Debug"
+ USE_STATIC_CRT: "ON"
+ - JOB: "Build"
+ GENERATOR: Visual Studio 14 2015 Win64
+ PYTHON: "3.5"
+ ARCH: "64"
+ CONFIGURATION: "Release"
+ USE_STATIC_CRT: "ON"
Review comment:
New two Appveyor's entries with USE_STATIC_CRT defined (for Debug and
Release) are added because different incompatible runtimes are used in both new
Appveyor's entries and all libs should be built with exact version of runtime.
( "All modules passed to a given invocation of the linker must have been
compiled with the same run-time library compiler option (/MD, /MT, /LD)." From
[here](https://msdn.microsoft.com/en-us/library/2kzt1wy3.aspx). Also debug uses
unique /MDd and /MTd runtimes.)
Probably, we can left only Debug build with USE_STATIC_CRT enabled, since it
builds only Arrow CPP and takes less time. How about this?
And here it's the list of others available Appveyor's build job entries:
- JOB: "Cmake_Script_Tests" // Verification that 3rd party libs are found
from toolchain and we don't use default built by us (passing very fast in
comparison with others)
- JOB: "Build" , GENERATOR: NMake Makefiles, CONFIGURATION: "Release" //
Full Release build with "NMake Makefiles" generator. Probably, we can reduce
build time to build only Arrow CPP ?
- JOB: "Build_Debug" GENERATOR: Visual Studio 14 2015 Win64 CONFIGURATION:
"Debug" // Debug build of only Arrow CPP with Visual Studio 14 2015 Win64
generator. Makes sure that we don't have issues with CMAKE multiconfiguration
(Both Debug and Release configs are available on build time when Visual Studio
14 2015 Win64 generator is used)
- JOB: "Build" GENERATOR: Visual Studio 14 2015 Win64 CONFIGURATION:
"Release" // Full Release build with "Visual Studio 14 2015 Win64" generator.
That's supposed (at least by me and seems in docs as well) as most widely used
build case.
- JOB: "Toolchain" GENERATOR: Visual Studio 14 2015 Win64 CONFIGURATION:
"Release" // Release build using conda-forge Toolchain and "Visual Studio 14
2015 Win64" generator. We have this to catch toolchain build issues as soon as
possible (if something broken in conda-forge)
- JOB: "Build" GENERATOR: Visual Studio 15 2017 Win64
APPVEYOR_BUILD_WORKER_IMAGE: Visual Studio 2017 // Full release build with
Visual Studio 2017 compiler. Not sure how this important since msvc compiler
for Visual Studio 2017 is pretty similar to VS2015, but Appveyor infrastructure
installs latest service packs for Visual Studio 2017 time to time and might
have sense to be sure that we support latest versions of msvc.
With 2 changes mentioned above, current build time (which is pretty long
already actually) might not increase a long, but coverage will be a little bit
affected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++] Add build options for MSVC to use static runtime libraries
> ----------------------------------------------------------------
>
> Key: ARROW-1755
> URL: https://issues.apache.org/jira/browse/ARROW-1755
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Wes McKinney
> Assignee: Max Risuhin
> Labels: pull-request-available
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
