[
https://issues.apache.org/jira/browse/ARROW-1755?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16269111#comment-16269111
]
ASF GitHub Bot commented on ARROW-1755:
---------------------------------------
wesm commented on a change in pull request #1333: ARROW-1755: [C++] CMake
option to link msvc crt statically
URL: https://github.com/apache/arrow/pull/1333#discussion_r153567651
##########
File path: appveyor.yml
##########
@@ -40,6 +40,18 @@ environment:
PYTHON: "3.5"
ARCH: "64"
CONFIGURATION: "Release"
+ - JOB: "Build_Debug"
+ GENERATOR: Visual Studio 14 2015 Win64
+ PYTHON: "3.5"
+ ARCH: "64"
+ CONFIGURATION: "Debug"
+ USE_STATIC_CRT: "ON"
+ - JOB: "Build"
+ GENERATOR: Visual Studio 14 2015 Win64
+ PYTHON: "3.5"
+ ARCH: "64"
+ CONFIGURATION: "Release"
+ USE_STATIC_CRT: "ON"
Review comment:
How about building both the static and dynamic versions in the same build
job? It's only necessary to build the C++ library, I think, for this. For the
Python tests we can use the dynamic version
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++] Add build options for MSVC to use static runtime libraries
> ----------------------------------------------------------------
>
> Key: ARROW-1755
> URL: https://issues.apache.org/jira/browse/ARROW-1755
> Project: Apache Arrow
> Issue Type: Improvement
> Components: C++
> Reporter: Wes McKinney
> Assignee: Max Risuhin
> Labels: pull-request-available
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
