[
https://issues.apache.org/jira/browse/ARROW-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16269661#comment-16269661
]
ASF GitHub Bot commented on ARROW-1816:
---------------------------------------
BryanCutler commented on a change in pull request #1330: ARROW-1816: [Java]
Resolve new vector classes structure for timestamp, date and maybe interval
URL: https://github.com/apache/arrow/pull/1330#discussion_r153652065
##########
File path:
java/vector/src/main/codegen/templates/AbstractPromotableFieldWriter.java
##########
@@ -42,6 +43,8 @@
* @param type the type of the values we want to write
* @return the corresponding field writer
*/
+ abstract protected FieldWriter getWriter(ArrowType type);
+
abstract protected FieldWriter getWriter(MinorType type);
Review comment:
Is is possible to just have `getWriter(ArrowType)`? Having 2 methods so
similar is a little confusing.. This is because you need a writer for a
specific time unit now?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Java] Resolve new vector classes structure for timestamp, date and maybe
> interval
> ----------------------------------------------------------------------------------
>
> Key: ARROW-1816
> URL: https://issues.apache.org/jira/browse/ARROW-1816
> Project: Apache Arrow
> Issue Type: Sub-task
> Reporter: Li Jin
> Assignee: Li Jin
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> Personally I think having 8 vector classes for timestamps is not great. This
> is discussed at some point during the PR:
> https://github.com/apache/arrow/pull/1203#discussion_r145241388
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
