[
https://issues.apache.org/jira/browse/ARROW-1816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16262940#comment-16262940
]
ASF GitHub Bot commented on ARROW-1816:
---------------------------------------
BryanCutler commented on a change in pull request #1330: ARROW-1816: [Java]
Resolve new vector classes structure for timestamp, date and maybe interval
URL: https://github.com/apache/arrow/pull/1330#discussion_r152630009
##########
File path:
java/vector/src/main/java/org/apache/arrow/vector/types/TimeUnit.java
##########
@@ -19,10 +19,10 @@
package org.apache.arrow.vector.types;
public enum TimeUnit {
- SECOND(org.apache.arrow.flatbuf.TimeUnit.SECOND),
- MILLISECOND(org.apache.arrow.flatbuf.TimeUnit.MILLISECOND),
- MICROSECOND(org.apache.arrow.flatbuf.TimeUnit.MICROSECOND),
- NANOSECOND(org.apache.arrow.flatbuf.TimeUnit.NANOSECOND);
+ SECOND(org.apache.arrow.flatbuf.TimeUnit.SECOND,
java.util.concurrent.TimeUnit.SECONDS),
+ MILLISECOND(org.apache.arrow.flatbuf.TimeUnit.MILLISECOND,
java.util.concurrent.TimeUnit.MILLISECONDS),
+ MICROSECOND(org.apache.arrow.flatbuf.TimeUnit.MICROSECOND,
java.util.concurrent.TimeUnit.MICROSECONDS),
+ NANOSECOND(org.apache.arrow.flatbuf.TimeUnit.NANOSECOND,
java.util.concurrent.TimeUnit.NANOSECONDS);
Review comment:
Well before the enum was defined by the flatbufId, but here it is the
flatbufId and the Java TimeUnit which is redundant information. So a check for
equality would have to look at both of these fields. Maybe not a big deal
though..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Java] Resolve new vector classes structure for timestamp, date and maybe
> interval
> ----------------------------------------------------------------------------------
>
> Key: ARROW-1816
> URL: https://issues.apache.org/jira/browse/ARROW-1816
> Project: Apache Arrow
> Issue Type: Sub-task
> Reporter: Li Jin
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> Personally I think having 8 vector classes for timestamps is not great. This
> is discussed at some point during the PR:
> https://github.com/apache/arrow/pull/1203#discussion_r145241388
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
