[
https://issues.apache.org/jira/browse/ARROW-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16274810#comment-16274810
]
ASF GitHub Bot commented on ARROW-1866:
---------------------------------------
BryanCutler commented on issue #1371: ARROW-1866: [Java] Combine MapVector
classes and remove NonNullableMapVector
URL: https://github.com/apache/arrow/pull/1371#issuecomment-348577147
I'm also willing to make downstream changes to Dremio if that would help. I
think the underlying issue here is that I (and I believe Li too) was under the
assumption that removing the non-nullable MapVector was part of the agenda for
the Java refactoring, while @siddharthteotia wants keep as they were before
ARROW-1710. Here are the options we have, as I see it, to proceed:
1. Keep this PR open and assess the impact on downstream projects. If all
checks out, then hopefully we can get this in before 0.8.0 is cut.
2. Close this PR for now. Since we are planning to change the name of
`MapVector` (this is still part of the refactoring plan for 0.8.0?) then start
with that and rename to `NullableStructVector` and `StructVector` or some
variant.
3. Close this PR for now, change the names back to `NullableMapVector` and
`MapVector`, hold off on renaming to StructVector, and put these in a future
plan to discuss later.
Of course I prefer (1) but I understand if constraints prevent this, it
would just be nice to get confirmation if that is the case and if there is
disagreement with doing (2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Java] Combine MapVector and NonNullableMapVector Classes
> ---------------------------------------------------------
>
> Key: ARROW-1866
> URL: https://issues.apache.org/jira/browse/ARROW-1866
> Project: Apache Arrow
> Issue Type: Sub-task
> Components: Java - Vectors
> Reporter: Bryan Cutler
> Assignee: Bryan Cutler
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> {{NonNullableMapVector}} class can be merged into {{MapVector}} and removed
> as part of removing the non nullable vectors.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
