[
https://issues.apache.org/jira/browse/ARROW-1866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16275404#comment-16275404
]
ASF GitHub Bot commented on ARROW-1866:
---------------------------------------
jacques-n commented on issue #1371: ARROW-1866: [Java] Combine MapVector
classes and remove NonNullableMapVector
URL: https://github.com/apache/arrow/pull/1371#issuecomment-348667143
What do people think of?
* Keep the two level hierarchy
* Rename NonNullableMapVector > StructVector
* Mark existing MapVector as deprecated
@BryanCutler, I think the SingleMapWriter has more differences than
Nullability. I think it is specifically used to treat the top of a record as a
pseudo-map where needed.
We do some fairly complex runtime code generation associated with this
structure in Dremio. It relates to these pieces of code [1][2][3] (among
others) and it will take some time to really remember & understand the impact
of what you're proposing to provide good feedback.
[1]
https://github.com/dremio/dremio-oss/blob/master/sabot/kernel/src/main/java/org/apache/arrow/vector/complex/FieldIdUtil2.java
[2]
https://github.com/dremio/dremio-oss/blob/master/sabot/kernel/src/main/java/com/dremio/exec/expr/EvaluationVisitor.java#L341
[3]
https://github.com/dremio/dremio-oss/blob/master/sabot/kernel/src/main/java/com/dremio/exec/expr/EvaluationVisitor.java#L405
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Java] Combine MapVector and NonNullableMapVector Classes
> ---------------------------------------------------------
>
> Key: ARROW-1866
> URL: https://issues.apache.org/jira/browse/ARROW-1866
> Project: Apache Arrow
> Issue Type: Sub-task
> Components: Java - Vectors
> Reporter: Bryan Cutler
> Assignee: Bryan Cutler
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> {{NonNullableMapVector}} class can be merged into {{MapVector}} and removed
> as part of removing the non nullable vectors.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
