[
https://issues.apache.org/jira/browse/ARROW-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276023#comment-16276023
]
ASF GitHub Bot commented on ARROW-1839:
---------------------------------------
cpcloud commented on a change in pull request #1335: ARROW-1839/ARROW-1871:
[C++/Python] Add Decimal Parquet Read/Write Tests
URL: https://github.com/apache/arrow/pull/1335#discussion_r154532186
##########
File path: python/pyarrow/tests/test_parquet.py
##########
@@ -1564,3 +1568,42 @@ def
test_backwards_compatible_index_multi_level_some_named():
t = _read_table(path)
result = t.to_pandas()
tm.assert_frame_equal(result, expected)
+
+
[email protected](
+ ('precision', 'scale'),
+ [
+ (precision, scale)
+ for precision in range(1, 39)
+ for scale in range(0, precision + 1)
Review comment:
This is generating a ton of tests, I will move the `scale` inside the
function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++/Python] Add Decimal Parquet Read/Write Tests
> -------------------------------------------------
>
> Key: ARROW-1839
> URL: https://issues.apache.org/jira/browse/ARROW-1839
> Project: Apache Arrow
> Issue Type: Test
> Components: C++, Python
> Affects Versions: 0.7.1
> Reporter: Phillip Cloud
> Assignee: Phillip Cloud
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)