[
https://issues.apache.org/jira/browse/ARROW-1839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16276100#comment-16276100
]
ASF GitHub Bot commented on ARROW-1839:
---------------------------------------
wesm commented on a change in pull request #1335: ARROW-1839/ARROW-1871:
[C++/Python] Add Decimal Parquet Read/Write Tests
URL: https://github.com/apache/arrow/pull/1335#discussion_r154537092
##########
File path: cpp/src/arrow/util/decimal.h
##########
@@ -146,6 +146,9 @@ ARROW_EXPORT Decimal128 operator*(const Decimal128& left,
const Decimal128& righ
ARROW_EXPORT Decimal128 operator/(const Decimal128& left, const Decimal128&
right);
ARROW_EXPORT Decimal128 operator%(const Decimal128& left, const Decimal128&
right);
+Status Rescale(const Decimal128& value, int32_t original_scale, int32_t
new_scale,
Review comment:
I'm renaming this to `RescaleDecimal` since it might be ambiguous in the
`arrow` namespace otherwise
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++/Python] Add Decimal Parquet Read/Write Tests
> -------------------------------------------------
>
> Key: ARROW-1839
> URL: https://issues.apache.org/jira/browse/ARROW-1839
> Project: Apache Arrow
> Issue Type: Test
> Components: C++, Python
> Affects Versions: 0.7.1
> Reporter: Phillip Cloud
> Assignee: Phillip Cloud
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
