[
https://issues.apache.org/jira/browse/ARROW-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16277315#comment-16277315
]
ASF GitHub Bot commented on ARROW-1864:
---------------------------------------
icexelloss commented on a change in pull request #1376: ARROW-1864: [Java]
Upgrade Netty to 4.1.17
URL: https://github.com/apache/arrow/pull/1376#discussion_r154749023
##########
File path:
java/memory/src/main/java/org/apache/arrow/memory/ArrowByteBufAllocator.java
##########
@@ -146,4 +147,45 @@ private RuntimeException fail() {
throw new UnsupportedOperationException("Allocator doesn't support
heap-based memory.");
}
+ /**
+ * This method was copied from AbstractByteBufAllocator. Netty 4.1.x moved
this method from
Review comment:
Does it make sense to change:
```
public class ArrowByteBufAllocator implements ByteBufAllocator
```
to
```
public class ArrowByteBufAllocator extends AbstractByteBufAllocator
```
?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Java] Upgrade Netty to 4.1.x
> -----------------------------
>
> Key: ARROW-1864
> URL: https://issues.apache.org/jira/browse/ARROW-1864
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Java - Memory
> Reporter: Shixiong Zhu
> Assignee: Shixiong Zhu
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> The Netty community will declare Netty 4.0.x as EOL at the beginning of the
> second quarter of 2018: https://github.com/netty/netty/issues/7439
> It would be great that Arrow can migrate to Netty 4.1.x soon. This is the
> only blocker for Spark to migrate to Netty 4.1.x.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
