[
https://issues.apache.org/jira/browse/ARROW-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16277370#comment-16277370
]
ASF GitHub Bot commented on ARROW-1864:
---------------------------------------
siddharthteotia commented on issue #1376: ARROW-1864: [Java] Upgrade Netty to
4.1.17
URL: https://github.com/apache/arrow/pull/1376#issuecomment-349082941
Thanks @zsxwing for addressing the earlier review comments and adding
description to PR.
As you mentioned the new method names are slightly confusing.
If I understand it correctly, setIntLE will write a LE int to ArrowBuf in BE
byte order and getIntLE will get a BE int. Both functions are essentially
swapping the bytes when reading/writing from/to ArrowBuf
Can you add some javadoc for each such function to explain the behavior?
Similarly there are some *medium* functions newly introduced. It would be good
to add javadoc for the same.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Java] Upgrade Netty to 4.1.x
> -----------------------------
>
> Key: ARROW-1864
> URL: https://issues.apache.org/jira/browse/ARROW-1864
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Java - Memory
> Reporter: Shixiong Zhu
> Assignee: Shixiong Zhu
> Labels: pull-request-available
> Fix For: 0.8.0
>
>
> The Netty community will declare Netty 4.0.x as EOL at the beginning of the
> second quarter of 2018: https://github.com/netty/netty/issues/7439
> It would be great that Arrow can migrate to Netty 4.1.x soon. This is the
> only blocker for Spark to migrate to Netty 4.1.x.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
