[
https://issues.apache.org/jira/browse/ARROW-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293997#comment-16293997
]
ASF GitHub Bot commented on ARROW-1927:
---------------------------------------
JinHai-CN commented on a change in pull request #1427: ARROW-1927: [Plasma] Add
delete function
URL: https://github.com/apache/arrow/pull/1427#discussion_r157356903
##########
File path: cpp/src/plasma/store.cc
##########
@@ -411,6 +411,39 @@ int PlasmaStore::abort_object(const ObjectID& object_id,
Client* client) {
}
}
+int PlasmaStore::delete_object(ObjectID& object_id) {
Review comment:
To be honest, they are similar. But in delete_object will issue the error
status to client if delete object failed. As for delete_objects used by evict
objects function, I don't want to impact it too much.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Plasma] Implement delete function
> ----------------------------------
>
> Key: ARROW-1927
> URL: https://issues.apache.org/jira/browse/ARROW-1927
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Plasma (C++), Python
> Reporter: Philipp Moritz
> Labels: pull-request-available
>
> The function should check if the reference count of the object is zero and if
> yes, delete it from the store. If no, it should raise an exception or return
> a status value.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
