[
https://issues.apache.org/jira/browse/ARROW-1927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16293998#comment-16293998
]
ASF GitHub Bot commented on ARROW-1927:
---------------------------------------
JinHai-CN commented on issue #1427: ARROW-1927: [Plasma] Add delete function
URL: https://github.com/apache/arrow/pull/1427#issuecomment-352229791
Yes, I will try to create the unit test cases in next commitment.
> On 17 Dec 2017, at 11:40 AM, Philipp Moritz <[email protected]>
wrote:
>
> @pcmoritz commented on this pull request.
>
> Hey, this looks good, thanks for the contribution! Can you please also
create a unit test that tests the following two scenarios:
>
> make sure an error is raised if the object is in use
> test the "normal" case where the object is not in use and make sure it was
actually deleted (maybe by trying to create an object with the same object id)
> maybe test what happens if an object is deleted that doesn't exist yet.
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
<https://github.com/apache/arrow/pull/1427#pullrequestreview-83989260>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/Afm26VC0v8ihrTN7qCYl8g60TEQ7M519ks5tBI0hgaJpZM4REiBf>.
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Plasma] Implement delete function
> ----------------------------------
>
> Key: ARROW-1927
> URL: https://issues.apache.org/jira/browse/ARROW-1927
> Project: Apache Arrow
> Issue Type: Improvement
> Components: Plasma (C++), Python
> Reporter: Philipp Moritz
> Labels: pull-request-available
>
> The function should check if the reference count of the object is zero and if
> yes, delete it from the store. If no, it should raise an exception or return
> a status value.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
