[
https://issues.apache.org/jira/browse/ARROW-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16294274#comment-16294274
]
Max Risuhin commented on ARROW-1931:
------------------------------------
[~wesmckinn] it seems that appearing of this warning was already addressed in
master branch of gtest
[there|https://github.com/google/googletest/blob/master/googletest/include/gtest/internal/gtest-port.h#L645]
, but these changes are not included in latest release of gtest which is used
by Arrow.
How acceptable can be just to try to upgrade version of gtest to the latest in
master or maybe (if incompatibility compilation errors will appear) to commit
with above referenced changes?
> [C++] w4996 warning due to std::tr1 failing builds on Visual Studio 2017
> ------------------------------------------------------------------------
>
> Key: ARROW-1931
> URL: https://issues.apache.org/jira/browse/ARROW-1931
> Project: Apache Arrow
> Issue Type: New Feature
> Components: C++
> Affects Versions: 0.8.0
> Reporter: Wes McKinney
> Fix For: 0.9.0
>
>
> See for example. [~Max Risuhin] do you know what is the most appropriate fix
> (besides silencing the deprecation warning)?
> {code}
> C:\projects\arrow\cpp\build\googletest_ep-prefix\src\googletest_ep\googletest\include\gtest/internal/gtest-port.h(996):
> warning C4996: 'std::tr1': warning STL4002: The non-Standard std::tr1
> namespace and TR1-only machinery are deprecated and will be REMOVED. You can
> define _SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING to acknowledge that you
> have received this warning.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
