[
https://issues.apache.org/jira/browse/ARROW-1931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16300246#comment-16300246
]
ASF GitHub Bot commented on ARROW-1931:
---------------------------------------
MaxRis commented on issue #1433: ARROW-1931: [C++] Suppress C4996 deprecation
warning in MSVC builds for now
URL: https://github.com/apache/arrow/pull/1433#issuecomment-353396851
@wesm
[this](https://github.com/MaxRis/arrow/commit/cfcd9c224aea495c2414a161ac6242bb59bf00d1)
seems should work fine
VS 2017 build is passed there
https://ci.appveyor.com/project/MaxRisuhin/arrow (I've temporary moved VS2017
Appveyor build job at first place and also some logging should be removed from
my changes )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++] w4996 warning due to std::tr1 failing builds on Visual Studio 2017
> ------------------------------------------------------------------------
>
> Key: ARROW-1931
> URL: https://issues.apache.org/jira/browse/ARROW-1931
> Project: Apache Arrow
> Issue Type: New Feature
> Components: C++
> Affects Versions: 0.8.0
> Reporter: Wes McKinney
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> See for example. [~Max Risuhin] do you know what is the most appropriate fix
> (besides silencing the deprecation warning)?
> {code}
> C:\projects\arrow\cpp\build\googletest_ep-prefix\src\googletest_ep\googletest\include\gtest/internal/gtest-port.h(996):
> warning C4996: 'std::tr1': warning STL4002: The non-Standard std::tr1
> namespace and TR1-only machinery are deprecated and will be REMOVED. You can
> define _SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING to acknowledge that you
> have received this warning.
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
