[
https://issues.apache.org/jira/browse/ARROW-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336443#comment-16336443
]
ASF GitHub Bot commented on ARROW-633:
--------------------------------------
alphalfalfa commented on a change in pull request #1492: ARROW-633/634: Add
FixedSizeBinary support in Java and integration tests (Updated)
URL: https://github.com/apache/arrow/pull/1492#discussion_r163391479
##########
File path: integration/integration_test.py
##########
@@ -525,6 +568,22 @@ def _get_buffers(self):
]
+class FixedSizeBinaryColumn(PrimitiveColumn):
+
+ def _encode_value(self, x):
+ return ''.join('{:02x}'.format(c).upper() for c in x)
+
+ def _get_buffers(self):
+ data = []
+ for i, v in enumerate(self.values):
+ data.append(self._encode_value(v if self.is_valid[i] else ""))
Review comment:
made the changes and simplified the logic inside JsonFileReader
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Java] Add support for FixedSizeBinary type
> -------------------------------------------
>
> Key: ARROW-633
> URL: https://issues.apache.org/jira/browse/ARROW-633
> Project: Apache Arrow
> Issue Type: New Feature
> Components: Java - Vectors
> Reporter: Wes McKinney
> Assignee: Jingyuan Wang
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
