[
https://issues.apache.org/jira/browse/ARROW-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346015#comment-16346015
]
ASF GitHub Bot commented on ARROW-633:
--------------------------------------
BryanCutler commented on a change in pull request #1492: ARROW-633/634: Add
FixedSizeBinary support in Java and integration tests (Updated)
URL: https://github.com/apache/arrow/pull/1492#discussion_r164915043
##########
File path: java/vector/src/main/java/org/apache/arrow/vector/BufferLayout.java
##########
@@ -70,7 +70,7 @@ public static BufferLayout dataBuffer(int typeBitWidth) {
case 128:
return VALUES_128;
default:
- throw new IllegalArgumentException("only 8, 16, 32, or 64 bits
supported");
+ return new BufferLayout(BufferType.DATA, typeBitWidth);
Review comment:
I think function is really "get data buffer layout for types that support
certain bit widths" - so it might be beneficial to keep the exception, although
it looks like it should be updated to include 128. I'm not sure how exactly
the exception would be thrown, but if somehow a buffer layout for an `Int` with
30 bit width was created, this would catch it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Java] Add support for FixedSizeBinary type
> -------------------------------------------
>
> Key: ARROW-633
> URL: https://issues.apache.org/jira/browse/ARROW-633
> Project: Apache Arrow
> Issue Type: New Feature
> Components: Java - Vectors
> Reporter: Wes McKinney
> Assignee: Jingyuan Wang
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
