ASF GitHub Bot commented on ARROW-1361:

BryanCutler commented on issue #972: ARROW-1361: [Java] Adding methods to get 
type param values in NullableValueVector
URL: https://github.com/apache/arrow/pull/972#issuecomment-362665086
   Yeah I've been meaning to look into this. It seems like not so much a
   requirement for me any more but I can still do it if you think it's a
   useful addition?
   On Feb 2, 2018 9:21 AM, "Li Jin" <notificati...@github.com> wrote:
   > Hey @BryanCutler <https://github.com/bryancutler> seems like the changes
   > here can be made on the new vectors now. Do you still want to add the
   > methods?
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/arrow/pull/972#issuecomment-362635593>, or mute
   > the thread
   > .

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> [Java] Add minor type param accessors to NullableValueVectors
> -------------------------------------------------------------
>                 Key: ARROW-1361
>                 URL: https://issues.apache.org/jira/browse/ARROW-1361
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: Java - Vectors
>            Reporter: Bryan Cutler
>            Assignee: Bryan Cutler
>            Priority: Major
>              Labels: pull-request-available
> A {{NullableValueVector}} creates private copies of each param in the minor 
> type, but does not have any way public api to access them.  So if given a 
> {{NullableValueVector}} you would have to use the {{Field}} and cast to the 
> correct type.  For example, with a {{NullableTimeStampMicroTZVector}} and 
> trying to get the timezone:
> {noformat}
> if field.getType.isInstanceOf[ArrowType.Timestamp] &&
>           field.getType.asInstanceOf[ArrowType.Timestamp].getTimezone
> {noformat}
> It would be more convenient to have direct accessors for these type params.  
> Also, it is possible to do some minor refactoring because 
> {{NullableValueVectors}} does not use these type params, so there is no need 
> to store them.  They already exist in the inner vector object and the Field 
> type.

This message was sent by Atlassian JIRA

Reply via email to