ASF GitHub Bot commented on ARROW-1361:

icexelloss commented on issue #972: ARROW-1361: [Java] Adding methods to get 
type param values in NullableValueVector
URL: https://github.com/apache/arrow/pull/972#issuecomment-362672731
   Yeah I think `DecimalVector` should have `getPrecision()` and `getScale()` 
methods. Unfortunately(?) now we need to do this on a vector by vector basis. 
`FixedSizeListVector` already has `getListSize()`. I checked other vectors 
seems to be fine.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> [Java] Add minor type param accessors to NullableValueVectors
> -------------------------------------------------------------
>                 Key: ARROW-1361
>                 URL: https://issues.apache.org/jira/browse/ARROW-1361
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: Java - Vectors
>            Reporter: Bryan Cutler
>            Assignee: Bryan Cutler
>            Priority: Major
>              Labels: pull-request-available
> A {{NullableValueVector}} creates private copies of each param in the minor 
> type, but does not have any way public api to access them.  So if given a 
> {{NullableValueVector}} you would have to use the {{Field}} and cast to the 
> correct type.  For example, with a {{NullableTimeStampMicroTZVector}} and 
> trying to get the timezone:
> {noformat}
> if field.getType.isInstanceOf[ArrowType.Timestamp] &&
>           field.getType.asInstanceOf[ArrowType.Timestamp].getTimezone
> {noformat}
> It would be more convenient to have direct accessors for these type params.  
> Also, it is possible to do some minor refactoring because 
> {{NullableValueVectors}} does not use these type params, so there is no need 
> to store them.  They already exist in the inner vector object and the Field 
> type.

This message was sent by Atlassian JIRA

Reply via email to