[ 
https://issues.apache.org/jira/browse/ARROW-633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355983#comment-16355983
 ] 

ASF GitHub Bot commented on ARROW-633:
--------------------------------------

alphalfalfa commented on issue #1492: ARROW-633/634: [Java] Add FixedSizeBinary 
support in Java and integration tests (Updated)
URL: https://github.com/apache/arrow/pull/1492#issuecomment-363893785
 
 
   @jacques-n, to make sure that I understand the question properly, do you 
mean there should be proper interfaces defined for FixedSizeBinary type inside 
AbstractFieldWriter and AbstractFieldReader? 
   Currently, AbstractFieldWriter has:
     `public void writeFixedSizeBinary(ArrowBuf buffer)`
   AbstractFieldReaderWriter has:
     `public byte[] readByteArray()`
   What would be the desired interfaces to add?
   
   I would prefer to add the necessary fix in a separate PR as this one has 
grown too big if it is OK. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> [Java] Add support for FixedSizeBinary type
> -------------------------------------------
>
>                 Key: ARROW-633
>                 URL: https://issues.apache.org/jira/browse/ARROW-633
>             Project: Apache Arrow
>          Issue Type: New Feature
>          Components: Java - Vectors
>            Reporter: Wes McKinney
>            Assignee: Jingyuan Wang
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 0.9.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to