[
https://issues.apache.org/jira/browse/ARROW-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16357438#comment-16357438
]
ASF GitHub Bot commented on ARROW-969:
--------------------------------------
wesm commented on a change in pull request #1574: ARROW-969: [C++] Add
add/remove field functions for RecordBatch
URL: https://github.com/apache/arrow/pull/1574#discussion_r167037896
##########
File path: cpp/src/arrow/table-test.cc
##########
@@ -588,6 +588,101 @@ TEST_F(TestRecordBatch, Slice) {
}
}
+TEST_F(TestRecordBatch, AddColumn) {
+ const int length = 10;
+
+ auto field1 = field("f1", int32());
+ auto field2 = field("f2", uint8());
+ auto field3 = field("f3", int16());
+
+ auto schema1 = ::arrow::schema({field1, field2});
+ auto schema2 = ::arrow::schema({field2, field3});
+ auto schema3 = ::arrow::schema({field2});
+
+ auto array1 = MakeRandomArray<Int32Array>(length);
+ auto array2 = MakeRandomArray<UInt8Array>(length);
+ auto array3 = MakeRandomArray<Int16Array>(length);
+
+ auto batch1 = RecordBatch::Make(schema1, length, {array1, array2});
+ auto batch2 = RecordBatch::Make(schema2, length, {array2, array3});
+ auto batch3 = RecordBatch::Make(schema3, length, {array2});
+
+ const RecordBatch& batch = *batch3;
+ std::shared_ptr<RecordBatch> result;
+
+ // Negative tests with invalid index
+ Status status = batch.AddColumn(5, field1, array1->data(), &result);
Review comment:
Add a test for `batch.AddColumn(2, ...)` to address the edge case in the
implementation. We probably need a corresponding test for `Table` (and maybe
also `Schema`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++/Python] Add add/remove field functions for RecordBatch
> -----------------------------------------------------------
>
> Key: ARROW-969
> URL: https://issues.apache.org/jira/browse/ARROW-969
> Project: Apache Arrow
> Issue Type: New Feature
> Components: C++, Python
> Reporter: Wes McKinney
> Assignee: Panchen Xue
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> Analogous to the Table equivalents
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
