[
https://issues.apache.org/jira/browse/ARROW-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16357435#comment-16357435
]
ASF GitHub Bot commented on ARROW-969:
--------------------------------------
wesm commented on a change in pull request #1574: ARROW-969: [C++] Add
add/remove field functions for RecordBatch
URL: https://github.com/apache/arrow/pull/1574#discussion_r167037500
##########
File path: cpp/src/arrow/record_batch.h
##########
@@ -96,6 +96,14 @@ class ARROW_EXPORT RecordBatch {
/// \return an internal ArrayData object
virtual std::shared_ptr<ArrayData> column_data(int i) const = 0;
+ /// \brief Add column to the record batch, producing a new RecordBatch
+ virtual Status AddColumn(int i, const std::shared_ptr<Field>& field,
+ const std::shared_ptr<ArrayData>& column,
+ std::shared_ptr<RecordBatch>* out) const = 0;
+
+ /// \brief Remove column from the record batch, producing a new RecordBatch
+ virtual Status RemoveColumn(int i, std::shared_ptr<RecordBatch>* out) const
= 0;
Review comment:
Can you document the parameters for these functions?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [C++/Python] Add add/remove field functions for RecordBatch
> -----------------------------------------------------------
>
> Key: ARROW-969
> URL: https://issues.apache.org/jira/browse/ARROW-969
> Project: Apache Arrow
> Issue Type: New Feature
> Components: C++, Python
> Reporter: Wes McKinney
> Assignee: Panchen Xue
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> Analogous to the Table equivalents
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
