ASF GitHub Bot commented on ARROW-2117:

wesm opened a new pull request #1597: ARROW-2117: [C++] Update codebase / CI 
toolchain for clang 5.0
URL: https://github.com/apache/arrow/pull/1597
   LLVM 5.0 found a number of code tidying issues that I fixed here. It also 
wants us to use `override` with our virtual destructor implementations, which I 
wasn't aware of whether is a best practice or not. 
   cc @xhochy @cpcloud for review

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> [C++] Pin clang to version 5.0
> ------------------------------
>                 Key: ARROW-2117
>                 URL: https://issues.apache.org/jira/browse/ARROW-2117
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>    Affects Versions: 0.9.0
>            Reporter: Phillip Cloud
>            Assignee: Phillip Cloud
>            Priority: Major
>              Labels: pull-request-available
> Let's do this after the next release.

This message was sent by Atlassian JIRA

Reply via email to