[ 
https://issues.apache.org/jira/browse/ARROW-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16362323#comment-16362323
 ] 

ASF GitHub Bot commented on ARROW-2117:
---------------------------------------

cpcloud commented on a change in pull request #1597: ARROW-2117: [C++] Update 
codebase / CI toolchain for clang 5.0
URL: https://github.com/apache/arrow/pull/1597#discussion_r167864138
 
 

 ##########
 File path: cpp/src/arrow/memory_pool.h
 ##########
 @@ -71,7 +71,7 @@ class ARROW_EXPORT MemoryPool {
 class ARROW_EXPORT LoggingMemoryPool : public MemoryPool {
  public:
   explicit LoggingMemoryPool(MemoryPool* pool);
-  virtual ~LoggingMemoryPool() = default;
+  ~LoggingMemoryPool() override = default;
 
 Review comment:
   I meant that you can't remove virtual destructors from base classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [C++] Pin clang to version 5.0
> ------------------------------
>
>                 Key: ARROW-2117
>                 URL: https://issues.apache.org/jira/browse/ARROW-2117
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>    Affects Versions: 0.9.0
>            Reporter: Phillip Cloud
>            Assignee: Phillip Cloud
>            Priority: Major
>              Labels: pull-request-available
>
> Let's do this after the next release.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to