[
https://issues.apache.org/jira/browse/ARROW-2144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16364700#comment-16364700
]
ASF GitHub Bot commented on ARROW-2144:
---------------------------------------
trxcllnt commented on a change in pull request #1599: ARROW-2144: [JS] Don't
repeat dictionary lookups in DataFrame ops
URL: https://github.com/apache/arrow/pull/1599#discussion_r168292856
##########
File path: js/src/vector.ts
##########
@@ -28,6 +28,7 @@ export interface View<T extends DataType> {
get(index: number): T['TValue'] | null;
set(index: number, value: T['TValue']): void;
toArray(): IterableArrayLike<T['TValue'] | null>;
+ find(search: T['TValue']): number | null;
Review comment:
@TheNeuralBit how do you feel about mirroring the Array/TypedArray
prototypes' naming convention and calling this
[`indexOf`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/indexOf)?
The built-ins also have
[`find`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/find)
and
[`findIndex`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/findIndex)
methods that take predicate functions, and may help JS folks already familiar
with these APIs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [JS] Don't repeat dictionary lookups in DataFrame ops
> -----------------------------------------------------
>
> Key: ARROW-2144
> URL: https://issues.apache.org/jira/browse/ARROW-2144
> Project: Apache Arrow
> Issue Type: Improvement
> Components: JavaScript
> Reporter: Brian Hulette
> Priority: Major
> Labels: pull-request-available
>
> Currently we repeat dictionary lookups every time we bind a new record batch
> when doing an equality check in a DataFrame op
> (https://github.com/apache/arrow/blob/master/js/src/predicate.ts#L143).
> In most cases the dictionary won't be changing between record batches, so we
> should remember these reverse dictionary lookups, either permanently, or at
> least for the duration of the current operation.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
