ASF GitHub Bot commented on ARROW-2144:

TheNeuralBit commented on issue #1599: ARROW-2144: [JS] Don't repeat dictionary 
lookups in DataFrame ops
URL: https://github.com/apache/arrow/pull/1599#issuecomment-366744742
   @wesm yeah I think this is good to go. I was waiting on a final :+1: from 
Paul, but we've already talked through the changes and I've updated as 
necessary. I guess I can try to follow the directions 
[here](https://github.com/apache/arrow/blob/master/dev/README.md) to merge this 
myself now?
   I'd also be interested in helping out with the release process if possible

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> [JS] Don't repeat dictionary lookups in DataFrame ops
> -----------------------------------------------------
>                 Key: ARROW-2144
>                 URL: https://issues.apache.org/jira/browse/ARROW-2144
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: JavaScript
>            Reporter: Brian Hulette
>            Priority: Major
>              Labels: pull-request-available
> Currently we repeat dictionary lookups every time we bind a new record batch 
> when doing an equality check in a DataFrame op 
> (https://github.com/apache/arrow/blob/master/js/src/predicate.ts#L143).
> In most cases the dictionary won't be changing between record batches, so we 
> should remember these reverse dictionary lookups, either permanently, or at 
> least for the duration of the current operation.

This message was sent by Atlassian JIRA

Reply via email to