[
https://issues.apache.org/jira/browse/ARROW-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16376832#comment-16376832
]
ASF GitHub Bot commented on ARROW-2214:
---------------------------------------
xhochy closed pull request #1659: ARROW-2214: [JS] add nullBitmap getter to
DictionaryData that proxies to its indices' nullBitmap
URL: https://github.com/apache/arrow/pull/1659
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/js/src/data.ts b/js/src/data.ts
index ab2e40ae9..d49fb790b 100644
--- a/js/src/data.ts
+++ b/js/src/data.ts
@@ -158,6 +158,7 @@ export class DictionaryData<T extends DataType> extends
BaseData<Dictionary<T>>
this.length = this._indicies.length;
}
public get nullCount() { return this._indicies.nullCount; }
+ public get nullBitmap() { return this._indicies.nullBitmap; }
public clone<R extends Dictionary<T>>(type: R, length = this.length,
offset = this.offset) {
const data = this._dictionary.data.clone(type.dictionary as any);
return new DictionaryData<R>(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [JS] proxy DictionaryVector's nullBitmap to its indices' nullBitmap
> -------------------------------------------------------------------
>
> Key: ARROW-2214
> URL: https://issues.apache.org/jira/browse/ARROW-2214
> Project: Apache Arrow
> Issue Type: Bug
> Components: JavaScript
> Affects Versions: JS-0.3.0
> Reporter: Paul Taylor
> Assignee: Paul Taylor
> Priority: Major
> Labels: pull-request-available
> Fix For: JS-0.4.0
>
>
> We need to add a {{nullBitmap}} getter to {{DictionaryData}} that proxies to
> the indices {{nullBitmap}}, like we do with the {{nullCount}}. This is
> blocking the PR that updates JPMC Perspective to v0.3.0:
> [https://github.com/jpmorganchase/perspective/pull/55#issuecomment-368164271|https://github.com/jpmorganchase/perspective/pull/55#issuecomment-368164271.].
> [~wesmckinn] can we do a patch release v0.3.1 once this PR is merged, since
> it's blocking a 3rd party PR?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
