[
https://issues.apache.org/jira/browse/ARROW-2214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16377110#comment-16377110
]
ASF GitHub Bot commented on ARROW-2214:
---------------------------------------
xhochy commented on issue #1659: ARROW-2214: [JS] add nullBitmap getter to
DictionaryData that proxies to its indices' nullBitmap
URL: https://github.com/apache/arrow/pull/1659#issuecomment-368558591
@nmichaud yes this is merged as a squashed commit in
https://github.com/apache/arrow/commit/27d83392ecb763c7ae0f3775a6c6582377998522
As there was no merge commit, this does look different in the GitHub UI
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [JS] proxy DictionaryVector's nullBitmap to its indices' nullBitmap
> -------------------------------------------------------------------
>
> Key: ARROW-2214
> URL: https://issues.apache.org/jira/browse/ARROW-2214
> Project: Apache Arrow
> Issue Type: Bug
> Components: JavaScript
> Affects Versions: JS-0.3.0
> Reporter: Paul Taylor
> Assignee: Paul Taylor
> Priority: Major
> Labels: pull-request-available
> Fix For: JS-0.4.0
>
>
> We need to add a {{nullBitmap}} getter to {{DictionaryData}} that proxies to
> the indices {{nullBitmap}}, like we do with the {{nullCount}}. This is
> blocking the PR that updates JPMC Perspective to v0.3.0:
> [https://github.com/jpmorganchase/perspective/pull/55#issuecomment-368164271|https://github.com/jpmorganchase/perspective/pull/55#issuecomment-368164271.].
> [~wesmckinn] can we do a patch release v0.3.1 once this PR is merged, since
> it's blocking a 3rd party PR?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
