ASF GitHub Bot commented on ARROW-2224:

cpcloud commented on issue #1880: ARROW-2224: [C++] Remove boost-regex 
URL: https://github.com/apache/arrow/pull/1880#issuecomment-380464015
   > It's not like isdigit is more readable anyway
   Readability wasn't my original concern, reimplementing a builtin function 
   > and apparently it risks being locale-dependent on Windows (which is a can 
of worms).
   Is there some documentation on this somewhere? I found the following lines 
in the [`setlocale` documentation for Visual Studio 
   The character-handling functions (except isdigit, isxdigit, mbstowcs, and 
mbtowc, which are unaffected).
   That suggests `isdigit` is *not* affected by locale. Am I reading something 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> [C++] Replace boost regex usage with libre2
> -------------------------------------------
>                 Key: ARROW-2224
>                 URL: https://issues.apache.org/jira/browse/ARROW-2224
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Phillip Cloud
>            Assignee: Phillip Cloud
>            Priority: Major
>              Labels: pull-request-available
> We're using {{boost::regex}} to parse decimal strings for {{decimal128}} 
> types. We should use {{libre2}} instead.

This message was sent by Atlassian JIRA

Reply via email to