ASF GitHub Bot commented on ARROW-2224:

pitrou commented on issue #1880: ARROW-2224: [C++] Remove boost-regex dependency
URL: https://github.com/apache/arrow/pull/1880#issuecomment-380464846
   I took it from here:
   > isdigit and isxdigit are the only standard narrow character classification 
functions that are not affected by the currently installed C locale. although 
some implementations (e.g. Microsoft in 1252 codepage) may classify additional 
single-byte characters as digits. 
   Not sure how authoritative that page is.
   That said, `static_cast<bool>(std::isdigit(c))` is not very pretty.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> [C++] Replace boost regex usage with libre2
> -------------------------------------------
>                 Key: ARROW-2224
>                 URL: https://issues.apache.org/jira/browse/ARROW-2224
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Phillip Cloud
>            Assignee: Phillip Cloud
>            Priority: Major
>              Labels: pull-request-available
> We're using {{boost::regex}} to parse decimal strings for {{decimal128}} 
> types. We should use {{libre2}} instead.

This message was sent by Atlassian JIRA

Reply via email to