[
https://issues.apache.org/jira/browse/ARROW-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436375#comment-16436375
]
ASF GitHub Bot commented on ARROW-2101:
---------------------------------------
cpcloud commented on a change in pull request #1886: Bug fix for ARROW-2101
URL: https://github.com/apache/arrow/pull/1886#discussion_r181236801
##########
File path: cpp/src/arrow/python/numpy_to_arrow.cc
##########
@@ -1393,7 +1412,13 @@ inline Status
NumPyConverter::ConvertTypedLists<NPY_OBJECT, StringType>(
RETURN_NOT_OK(CheckFlatNumpyArray(numpy_array, NPY_OBJECT));
int64_t offset = 0;
- RETURN_NOT_OK(AppendObjectStrings(numpy_array, nullptr, 0,
value_builder, &offset,
+ // If a type was specified and it was utf8, then we set
+ // check_valid to true. If any of the input cannot be
+ // converted, then we will exit early here.
+ auto check_valid = type_ != 0 && type_->Equals(::arrow::utf8());
Review comment:
`nullptr` here as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [Python] from_pandas reads 'str' type as binary Arrow data with Python 2
> ------------------------------------------------------------------------
>
> Key: ARROW-2101
> URL: https://issues.apache.org/jira/browse/ARROW-2101
> Project: Apache Arrow
> Issue Type: Bug
> Components: Python
> Affects Versions: 0.8.0
> Reporter: Bryan Cutler
> Assignee: Bryan Cutler
> Priority: Major
> Labels: pull-request-available
>
> Using Python 2, converting Pandas with 'str' data to Arrow results in Arrow
> data of binary type, even if the user supplies type information. conversion
> of 'unicode' type works to create Arrow data of string types. For example
> {code}
> In [25]: pa.Array.from_pandas(pd.Series(['a'])).type
> Out[25]: DataType(binary)
> In [26]: pa.Array.from_pandas(pd.Series(['a']), type=pa.string()).type
> Out[26]: DataType(binary)
> In [27]: pa.Array.from_pandas(pd.Series([u'a'])).type
> Out[27]: DataType(string)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
