[ 
https://issues.apache.org/jira/browse/ARROW-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436382#comment-16436382
 ] 

ASF GitHub Bot commented on ARROW-2101:
---------------------------------------

cpcloud commented on a change in pull request #1886: Bug fix for ARROW-2101
URL: https://github.com/apache/arrow/pull/1886#discussion_r181237392
 
 

 ##########
 File path: cpp/src/arrow/python/python-test.cc
 ##########
 @@ -383,5 +384,57 @@ TEST(PythonTest, ConstructStringArrayWithLeadingZeros) {
   ASSERT_OK(ConvertPySequence(list, pool, &out));
 }
 
+class NdarrayToArrowTest: public ::testing::Test {
+
+public:
+
+  void CreateNdarrayWithOneString(const char* value, OwnedRef& ref)
+  {
+    npy_intp dims[1];
+    dims[0] = 1;
+    auto array_object = PyArray_SimpleNew(1, dims, NPY_OBJECT);
+    auto array = reinterpret_cast<PyArrayObject*>(array_object);
+    ASSERT_TRUE(array != 0);
+    dims[0] = 0;
+    auto dest = PyArray_GetPtr(array, dims);
+    auto bytes_object = PyBytes_FromString(value);
 
 Review comment:
   Should we assert that this isn't `nullptr`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [Python] from_pandas reads 'str' type as binary Arrow data with Python 2
> ------------------------------------------------------------------------
>
>                 Key: ARROW-2101
>                 URL: https://issues.apache.org/jira/browse/ARROW-2101
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Python
>    Affects Versions: 0.8.0
>            Reporter: Bryan Cutler
>            Assignee: Bryan Cutler
>            Priority: Major
>              Labels: pull-request-available
>
> Using Python 2, converting Pandas with 'str' data to Arrow results in Arrow 
> data of binary type, even if the user supplies type information.  conversion 
> of 'unicode' type works to create Arrow data of string types.  For example
> {code}
> In [25]: pa.Array.from_pandas(pd.Series(['a'])).type
> Out[25]: DataType(binary)
> In [26]: pa.Array.from_pandas(pd.Series(['a']), type=pa.string()).type
> Out[26]: DataType(binary)
> In [27]: pa.Array.from_pandas(pd.Series([u'a'])).type
> Out[27]: DataType(string)
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to