[
https://issues.apache.org/jira/browse/ARROW-2101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437757#comment-16437757
]
ASF GitHub Bot commented on ARROW-2101:
---------------------------------------
pitrou commented on a change in pull request #1886: ARROW-2101: [Python/C++]
Correctly convert numpy arrays of bytes to arrow arrays of strings when user
specifies arrow type of string
URL: https://github.com/apache/arrow/pull/1886#discussion_r181482519
##########
File path: cpp/src/arrow/python/numpy_to_arrow.cc
##########
@@ -844,6 +846,13 @@ Status NumPyConverter::ConvertObjectStrings() {
StringBuilder builder(pool_);
RETURN_NOT_OK(builder.Resize(length_));
+ // If the creator of this NumPyConverter specified a type,
+ // then we want to force the output type to be utf8. If
+ // the input data is PyBytes and not PyUnicode and
+ // not convertible to utf8, the call to AppendObjectStrings
+ // below will fail because we pass force_string as the
+ // value for check_valid.
+ bool force_string = type_ != std::nullptr && type_->Equals(utf8());
Review comment:
Apparently some compilers don't like `std::nullptr`. Just use `type_ !=
nullptr`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> [Python] from_pandas reads 'str' type as binary Arrow data with Python 2
> ------------------------------------------------------------------------
>
> Key: ARROW-2101
> URL: https://issues.apache.org/jira/browse/ARROW-2101
> Project: Apache Arrow
> Issue Type: Bug
> Components: Python
> Affects Versions: 0.8.0
> Reporter: Bryan Cutler
> Assignee: Bryan Cutler
> Priority: Major
> Labels: pull-request-available
>
> Using Python 2, converting Pandas with 'str' data to Arrow results in Arrow
> data of binary type, even if the user supplies type information. conversion
> of 'unicode' type works to create Arrow data of string types. For example
> {code}
> In [25]: pa.Array.from_pandas(pd.Series(['a'])).type
> Out[25]: DataType(binary)
> In [26]: pa.Array.from_pandas(pd.Series(['a']), type=pa.string()).type
> Out[26]: DataType(binary)
> In [27]: pa.Array.from_pandas(pd.Series([u'a'])).type
> Out[27]: DataType(string)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
