[ 
https://issues.apache.org/jira/browse/ARROW-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16438504#comment-16438504
 ] 

ASF GitHub Bot commented on ARROW-2458:
---------------------------------------

pitrou commented on issue #1893: ARROW-2458: [Plasma] Use one thread pool per 
PlasmaClient
URL: https://github.com/apache/arrow/pull/1893#issuecomment-381360963
 
 
   > @pitrou the problem that you point exists regardless because we already 
give each client its own thread pool when the clients are isolated in different 
processes, and this preserves the behavior when the clients are in the same 
process.
   
   I don't think preserving a behavior which is clearly detrimental is a good 
idea. It's true that when several processes have a thread pool each, there can 
be excessive resource consumption, but that's not a reason to reproduce the 
problem inside a single process as well.
   
   By the way, it's not obvious to me what the issue is we are trying to solve. 
The JIRA issue says "This prevents us from using multiple PlasmaClients in the 
same process (one per thread)", but I don't understand why the current thread 
pool policy prevents that. Your clients will simply be sharing a single thread 
pool.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [Plasma] PlasmaClient uses global variable
> ------------------------------------------
>
>                 Key: ARROW-2458
>                 URL: https://issues.apache.org/jira/browse/ARROW-2458
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: Plasma (C++)
>    Affects Versions: 0.9.0
>            Reporter: Philipp Moritz
>            Assignee: Philipp Moritz
>            Priority: Major
>              Labels: pull-request-available
>
> The threadpool threadpool_ that PlasmaClient is using is global at the 
> moment. This prevents us from using multiple PlasmaClients in the same 
> process (one per thread).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to