[ 
https://issues.apache.org/jira/browse/ARROW-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16438616#comment-16438616
 ] 

ASF GitHub Bot commented on ARROW-2458:
---------------------------------------

xhochy commented on issue #1893: ARROW-2458: [Plasma] Use one thread pool per 
PlasmaClient
URL: https://github.com/apache/arrow/pull/1893#issuecomment-381387911
 
 
   > Note we could also take an existing header-only C++11 thread pool 
implementation (example: https://github.com/inkooboo/thread-pool-cpp), though 
I'm not sure what our policy is for vendoring code.
   
   @pitrou Vendoring code is ok. We need to clearly mark that the code is 
vendored, e.g. by placing in a `thirdparty` directory. Additionally, this 
should be lined out in the `NOTICE` and `LICENSE` files. I think an important 
component for ASF policies is that it must be visible what code is just 
vendored, not submitted a code donation.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> [Plasma] PlasmaClient uses global variable
> ------------------------------------------
>
>                 Key: ARROW-2458
>                 URL: https://issues.apache.org/jira/browse/ARROW-2458
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: Plasma (C++)
>    Affects Versions: 0.9.0
>            Reporter: Philipp Moritz
>            Assignee: Philipp Moritz
>            Priority: Major
>              Labels: pull-request-available
>
> The threadpool threadpool_ that PlasmaClient is using is global at the 
> moment. This prevents us from using multiple PlasmaClients in the same 
> process (one per thread).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to