gemmellr commented on code in PR #6119:
URL: https://github.com/apache/artemis/pull/6119#discussion_r2607640255
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ActiveMQServerControlTest.java:
##########
@@ -4385,10 +4386,9 @@ public void testListConsumers() throws Exception {
assertNotEquals("",
jsonConsumer.getString(ConsumerField.MESSAGES_DELIVERED.getName()),
"messagesDelivered");
assertNotEquals("",
jsonConsumer.getString(ConsumerField.MESSAGES_DELIVERED_SIZE.getName()),
"messagesDeliveredSize");
assertNotEquals("",
jsonConsumer.getString(ConsumerField.MESSAGES_ACKNOWLEDGED.getName()),
"messagesAcknowledged");
- assertEquals(0,
jsonConsumer.getInt(ConsumerField.LAST_DELIVERED_TIME.getName()),
"lastDeliveredTime");
- assertEquals(0,
jsonConsumer.getInt(ConsumerField.LAST_ACKNOWLEDGED_TIME.getName()),
"lastAcknowledgedTime");
+ assertNotEquals("",
jsonConsumer.getString(ConsumerField.LAST_DELIVERED_TIME.getName()),
"lastDeliveredTime");
+ assertNotEquals("",
jsonConsumer.getString(ConsumerField.LAST_ACKNOWLEDGED_TIME.getName()),
"lastAcknowledgedTime");
Review Comment:
I dont really 'get' this change, or more the previous one that broke the
test.
This was known to be a fixed 0 integer before your previous change, but now
all it checks is its got a non-empty string value. Was the prior 0 reflective
of not-delivering or not-acknowledging ? Would an empty value / absence not be
more reflective of that? From the other change I guess this a string saying
1970 etc for the epoch? Not sure it feels like an improvement, especially as
its a breaking change on top.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
