brusdev commented on code in PR #6119:
URL: https://github.com/apache/artemis/pull/6119#discussion_r2609368118
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/management/ActiveMQServerControlTest.java:
##########
@@ -4385,10 +4386,9 @@ public void testListConsumers() throws Exception {
assertNotEquals("",
jsonConsumer.getString(ConsumerField.MESSAGES_DELIVERED.getName()),
"messagesDelivered");
assertNotEquals("",
jsonConsumer.getString(ConsumerField.MESSAGES_DELIVERED_SIZE.getName()),
"messagesDeliveredSize");
assertNotEquals("",
jsonConsumer.getString(ConsumerField.MESSAGES_ACKNOWLEDGED.getName()),
"messagesAcknowledged");
- assertEquals(0,
jsonConsumer.getInt(ConsumerField.LAST_DELIVERED_TIME.getName()),
"lastDeliveredTime");
- assertEquals(0,
jsonConsumer.getInt(ConsumerField.LAST_ACKNOWLEDGED_TIME.getName()),
"lastAcknowledgedTime");
+ assertNotEquals("",
jsonConsumer.getString(ConsumerField.LAST_DELIVERED_TIME.getName()),
"lastDeliveredTime");
+ assertNotEquals("",
jsonConsumer.getString(ConsumerField.LAST_ACKNOWLEDGED_TIME.getName()),
"lastAcknowledgedTime");
Review Comment:
Some users also use the management API via the jolokia endpoint in JSON
format. The most commonly used JSON alternatives for timestamps are ISO 8601
strings and Unix epochs, because they are easier to parse.
I'm in favor of moving the final output formatting to the web console
because it would allow applying the user's local settings to the output format.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
