jbertram commented on code in PR #6171:
URL: https://github.com/apache/artemis/pull/6171#discussion_r2682954472
##########
artemis-docker/prepare-docker.sh:
##########
@@ -129,8 +129,8 @@ if [ -n "${FROM_RELEASE}" ]; then
# Check if the release is already available locally, if not try to download
it
if [ -z "$(ls -A ${ARTEMIS_DIST_DIR})" ]; then
- CDN="$(curl -s
https://www.apache.org/dyn/closer.cgi\?preferred=true)activemq/activemq-artemis/${ARTEMIS_VERSION}/"
-
ARCHIVE="https://archive.apache.org/dist/activemq/activemq-artemis/${ARTEMIS_VERSION}/";
+ CDN="$(curl -s
https://www.apache.org/dyn/closer.cgi\?preferred=true)artemis/${ARTEMIS_VERSION}/"
+ ARCHIVE="https://archive.apache.org/dist/artemis/${ARTEMIS_VERSION}/";
Review Comment:
I saw that. I wonder if _artemis_ and _artemis-console_ are the best names
for those directories. Is there a reason we couldn't use something like
_broker_ and _console_ instead? Having _artemis_ in multiple directory names of
the hierarchy seems redundant and potentially confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
