gemmellr commented on code in PR #6171:
URL: https://github.com/apache/artemis/pull/6171#discussion_r2683112091
##########
artemis-docker/prepare-docker.sh:
##########
@@ -129,8 +129,8 @@ if [ -n "${FROM_RELEASE}" ]; then
# Check if the release is already available locally, if not try to download
it
if [ -z "$(ls -A ${ARTEMIS_DIST_DIR})" ]; then
- CDN="$(curl -s
https://www.apache.org/dyn/closer.cgi\?preferred=true)activemq/activemq-artemis/${ARTEMIS_VERSION}/"
-
ARCHIVE="https://archive.apache.org/dist/activemq/activemq-artemis/${ARTEMIS_VERSION}/";
+ CDN="$(curl -s
https://www.apache.org/dyn/closer.cgi\?preferred=true)artemis/${ARTEMIS_VERSION}/"
+ ARCHIVE="https://archive.apache.org/dist/artemis/${ARTEMIS_VERSION}/";
Review Comment:
Its the same subdirs used previously which makes it easiest for folks to
update just the project dir alone in any references they might have. The
release distributions are named apache-artemis and apache-artemis-console, the
dirs they sit in are based on that (but drop out the apache-).
One reason not to use _broker_ would be that it doesnt just contain the
broker, and there would be no 'client', so it doesnt seem to fit that great
(unless we changed that).
I can see what you are saying, but I dont personally find it confusing at
all. The first dir is the project root, the next dir is the release/component
dir for organisation. I'm sure I've seen a variety of projects doing much the
same in having the project dir and then either an identical or similar subdir
(sometimes split further with e.g the major versions, or sometimes every
version dir but again containing the project name). I dont think its that
unusual.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
