[
https://issues.apache.org/jira/browse/ARTEMIS-5871?focusedWorklogId=1003012&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1003012
]
ASF GitHub Bot logged work on ARTEMIS-5871:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Feb/26 12:36
Start Date: 02/Feb/26 12:36
Worklog Time Spent: 10m
Work Description: gemmellr commented on PR #6205:
URL: https://github.com/apache/artemis/pull/6205#issuecomment-3834872659
> There is a use case where a user has a coded configuration impl that they
pass to the broker, if that contains re loadable config and there are the same
entries in a properties file that is reloaded, then the reload will take
precedence. In this case there are two sources of truth and one is re-loadable,
I think this is the expected behaviour, but due to this bug, it is not
currently the case.
I wont just 'take precedence', it could silently toss original configuration
even where they dont overlap at all, giving potentially a completely different
result than when the very same properties were applied at startup. So even
touching the file could alter config vs startup, which itself seems like an
issue.
FWIW, you added a startup class for use with images thats specifically using
that behaviour, and added ability to change the properties path on another
related embedding class that then allows it too, so youll likely need to look
at updating those, and some of the tests that use it, if you want to change
this.
Issue Time Tracking
-------------------
Worklog Id: (was: 1003012)
Time Spent: 40m (was: 0.5h)
> reload of broker properties config should be restricted to confined to
> re-loadable components
> ---------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-5871
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5871
> Project: Artemis
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 2.50.0
> Reporter: Gary Tully
> Assignee: Gary Tully
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> currently on reload config, broker properties are applied to the current
> broker config in error.
> This means that the absence of a value is not reflected in the config update,
> simply removing the properties does not result in a removed component or
> configuration entry.
> This is not consistent with the xml reload but also means for properties only
> config, there needs to be an explicit remove key=- value. which then needs to
> be removed.
> If config reload of properties are confined to a new config that is then
> compared in the normal way with the component reload logic, the properties
> can be the source of truth.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
