[
https://issues.apache.org/jira/browse/ARTEMIS-5871?focusedWorklogId=1003453&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1003453
]
ASF GitHub Bot logged work on ARTEMIS-5871:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Feb/26 12:18
Start Date: 04/Feb/26 12:18
Worklog Time Spent: 10m
Work Description: gemmellr commented on PR #6205:
URL: https://github.com/apache/artemis/pull/6205#issuecomment-3847116814
> @gemmellr I peeked at the image example tests, none have overlapping
re-loadable config. I cannot find any broken usage in our test suite.
The config doesnt actually need to 'overlap' for it to be a problem, its
arguably even more of an issue when it doesnt as then the original certainly
shouldnt be getting tossed.
The issue is also not going to be contained to our test suite.
We provide multiple APIs that allow providing Configuration objects, even
encourage it, or always do it. Your changes dont even try to stop that, they'll
just make it _silently_ do something _egregiously different_ than before.
> @gemmellr I peeked at the image example tests, none have overlapping
re-loadable config. I cannot find any broken usage in our test suite.
Again, this is not an issue contained to our test suite.
Check out the main ActiveMQServerImpl constructors, or the 'Main' which do
supply a Configuration, or EmbeddedActiveMQ which it uses and similarly can or
will do the same, and is used in various other places to that end.
Issue Time Tracking
-------------------
Worklog Id: (was: 1003453)
Time Spent: 1h 40m (was: 1.5h)
> reload of broker properties config should be restricted to confined to
> re-loadable components
> ---------------------------------------------------------------------------------------------
>
> Key: ARTEMIS-5871
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5871
> Project: Artemis
> Issue Type: Bug
> Components: Configuration
> Affects Versions: 2.50.0
> Reporter: Gary Tully
> Assignee: Gary Tully
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> currently on reload config, broker properties are applied to the current
> broker config in error.
> This means that the absence of a value is not reflected in the config update,
> simply removing the properties does not result in a removed component or
> configuration entry.
> This is not consistent with the xml reload but also means for properties only
> config, there needs to be an explicit remove key=- value. which then needs to
> be removed.
> If config reload of properties are confined to a new config that is then
> compared in the normal way with the component reload logic, the properties
> can be the source of truth.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
