tabish121 commented on code in PR #6268:
URL: https://github.com/apache/artemis/pull/6268#discussion_r2875189902
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/AMQPBrokerConnection.java:
##########
@@ -251,7 +276,20 @@ public synchronized void initialize() throws Exception {
}
@Override
- public synchronized void start() throws Exception {
+ public void start() throws Exception {
+
+ if (lockCoordinator != null) {
+ this.active = false;
+ // this needs to be started before the acceptor, hence a lower
priority on start
+ lockCoordinator.onLockAcquired(this::resume, 5);
Review Comment:
These priority values seem arbitrary and very difficult to correlate amongst
any future things that also need some specific priority settings. I'd
recommend at least creating some defined group values like PRIORITY_GROUP_A etc
that get run in order, where you could even use the same priority for both
entries and reverse sort for the released state. Having to search through
every usage to try and figure out what priority to set is not particularly
maintainable over time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
