tabish121 commented on code in PR #6268:
URL: https://github.com/apache/artemis/pull/6268#discussion_r2875206062
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/AMQPBrokerConnection.java:
##########
@@ -251,7 +276,20 @@ public synchronized void initialize() throws Exception {
}
@Override
- public synchronized void start() throws Exception {
+ public void start() throws Exception {
+
+ if (lockCoordinator != null) {
+ this.active = false;
Review Comment:
Active is set to false here but not set to false in stop leading to some
inconsistent states where you can be stopped but still active which seems like
it will lead to issues. Perhaps you don't actually need active / started but
instead a state enum or the like. Consider if it makes sense to be performing
mirror operations while stopped if active is left true all the time...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
