[
https://issues.apache.org/jira/browse/ARTEMIS-5925?focusedWorklogId=1007562&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1007562
]
ASF GitHub Bot logged work on ARTEMIS-5925:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Mar/26 23:24
Start Date: 02/Mar/26 23:24
Worklog Time Spent: 10m
Work Description: tabish121 commented on code in PR #6268:
URL: https://github.com/apache/artemis/pull/6268#discussion_r2875206062
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/AMQPBrokerConnection.java:
##########
@@ -251,7 +276,20 @@ public synchronized void initialize() throws Exception {
}
@Override
- public synchronized void start() throws Exception {
+ public void start() throws Exception {
+
+ if (lockCoordinator != null) {
+ this.active = false;
Review Comment:
Active is set to false here but not set to false in stop leading to some
inconsistent states where you can be stopped but still active which seems like
it will lead to issues. Perhaps you don't actually need active / started but
instead a state enum or the like. Consider if it makes sense to be performing
mirror operations while stopped if active is left true all the time...
Issue Time Tracking
-------------------
Worklog Id: (was: 1007562)
Time Spent: 1h 40m (was: 1.5h)
> Support Star Mirror Configuration on Lock Coordinator
> -----------------------------------------------------
>
> Key: ARTEMIS-5925
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5925
> Project: Artemis
> Issue Type: Improvement
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.53.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> The Lock Coordinator should be applied to Broker Connections.
> Notice that broker connection should also be made, however mirroring should
> not be capturing events while "paused". This is to guarantee past mirror
> events would be sent after a reconnect. StarMirrorSingleAcceptorRunningTest
> shows the need for this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
