[
https://issues.apache.org/jira/browse/ARTEMIS-5925?focusedWorklogId=1007566&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1007566
]
ASF GitHub Bot logged work on ARTEMIS-5925:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Mar/26 23:27
Start Date: 02/Mar/26 23:27
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #6268:
URL: https://github.com/apache/artemis/pull/6268#discussion_r2875219305
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/AMQPBrokerConnection.java:
##########
@@ -251,7 +276,20 @@ public synchronized void initialize() throws Exception {
}
@Override
- public synchronized void start() throws Exception {
+ public void start() throws Exception {
+
+ if (lockCoordinator != null) {
+ this.active = false;
+ // this needs to be started before the acceptor, hence a lower
priority on start
+ lockCoordinator.onLockAcquired(this::resume, 5);
Review Comment:
It is actually arbitrary. The thing here is that the priority needs to be
lower than the default priority used by the acceptor. This is to avoid a
client sending a message before mirror is installed as it would lead to message
loss.
Issue Time Tracking
-------------------
Worklog Id: (was: 1007566)
Time Spent: 2h 20m (was: 2h 10m)
> Support Star Mirror Configuration on Lock Coordinator
> -----------------------------------------------------
>
> Key: ARTEMIS-5925
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5925
> Project: Artemis
> Issue Type: Improvement
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.53.0
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> The Lock Coordinator should be applied to Broker Connections.
> Notice that broker connection should also be made, however mirroring should
> not be capturing events while "paused". This is to guarantee past mirror
> events would be sent after a reconnect. StarMirrorSingleAcceptorRunningTest
> shows the need for this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
