tabish121 commented on code in PR #6301:
URL: https://github.com/apache/artemis/pull/6301#discussion_r2955727848
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/AddressInfo.java:
##########
@@ -439,4 +439,17 @@ public static AddressInfo fromJSON(String jsonString) {
public long getCreatedTimestamp() {
return createdTimestamp;
}
+
+ @Override
+ public boolean equals(Object o) {
+ if (o == null || getClass() != o.getClass())
Review Comment:
Should be using brackets per our style policy
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/RoutingContextImpl.java:
##########
@@ -211,11 +212,11 @@ public void addQueue(final SimpleString address, final
Queue queue) {
listing.getNonDurableQueues().add(queue);
}
- if (internalOnly == null) {
- internalOnly = queue.isInternalQueue();
+ if (mirrorIgnore == null) {
+ mirrorIgnore = queue.isInternalQueue() || queue.isTemporary();
} else {
// every queue added has to be internal only
Review Comment:
Comment doesn't match the logic now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
