tabish121 commented on code in PR #6301:
URL: https://github.com/apache/artemis/pull/6301#discussion_r2961416761
##########
tests/integration-tests/src/test/java/org/apache/activemq/artemis/tests/integration/amqp/connect/BrokerInSyncTest.java:
##########
@@ -265,18 +266,89 @@ public void testSingleMessage(String protocol) throws
Exception {
session1.commit();
}
- try {
- connection1.close();
- } catch (Exception ignored) {
+ connection1.close();
+ connection2.close();
+
+ Wait.assertEquals(0L, queueOnServer1::getMessageCount, 5000, 100);
+ Wait.assertEquals(0L, queueOnServer2::getMessageCount, 5000, 100);
+
+ server_2.stop();
+ server.stop();
+ }
+
+ @Test
+ public void testNoTemporaryQueues() throws Exception {
Review Comment:
The test is named `testNoTemporaryQueues` but its creating temporary topics.
It would be nice to create a set of tests that exercise both to ensure the two
domains are covered in testing for the mirror. Should be simple enough the
create on method that does one type of the other and call it with an option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
